Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shorts, lives and long videos in the UI + fix shorts display #378

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

benoit74
Copy link
Collaborator

@benoit74 benoit74 commented Nov 26, 2024

Replace #371 to have proper CI operation

Fixes #366 #367

@benoit74 benoit74 self-assigned this Nov 26, 2024
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 35 lines in your changes missing coverage. Please review.

Project coverage is 1.24%. Comparing base (234e6fa) to head (246f9e1).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
scraper/src/youtube2zim/youtube.py 0.00% 16 Missing ⚠️
scraper/src/youtube2zim/scraper.py 0.00% 15 Missing ⚠️
scraper/src/youtube2zim/schemas.py 0.00% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main    #378      +/-   ##
========================================
- Coverage   1.25%   1.24%   -0.01%     
========================================
  Files         11      11              
  Lines       1120    1124       +4     
  Branches     165     164       -1     
========================================
  Hits          14      14              
- Misses      1106    1110       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benoit74 benoit74 force-pushed the fix/differentiate-shorts-lives-normal-videos branch from 5f7f4d6 to 246f9e1 Compare November 26, 2024 08:37
@benoit74 benoit74 marked this pull request as ready for review November 26, 2024 09:13
@benoit74
Copy link
Collaborator Author

Already reviewed with @arjitcodes ; thank you for the great work, let's merge!

@benoit74 benoit74 merged commit 7754caf into main Nov 26, 2024
9 of 10 checks passed
@benoit74 benoit74 deleted the fix/differentiate-shorts-lives-normal-videos branch November 26, 2024 09:14
@arjitcodes
Copy link
Contributor

Thank you, @benoit74 It was great working with you on this—it made the process smooth and enjoyable. Looking forward to more opportunities to work together in the future! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"shorts" videos resolution seems wrong (too high)
2 participants