Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unlisted videos must also be included inside the ZIM #379

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Unlisted videos must also be included inside the ZIM #379

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

- Corrected the short video resolution in the UI (#366)
- Check for empty playlists after filtering, and after downloading videos (#375)
- Unlisted videos must also be included inside the ZIM (#379)

## [3.2.1] - 2024-11-01

Expand Down
2 changes: 1 addition & 1 deletion scraper/src/youtube2zim/youtube.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,7 +332,7 @@

def skip_non_public_videos(item):
"""filter func to filter-out non-public videos"""
return item["status"]["privacyStatus"] == "public"
return item["status"]["privacyStatus"] in ("public", "unlisted")

Check warning on line 335 in scraper/src/youtube2zim/youtube.py

View check run for this annotation

Codecov / codecov/patch

scraper/src/youtube2zim/youtube.py#L335 

Added line #L335 was not covered by tests


def skip_outofrange_videos(date_range, item):
Expand Down