Fix: Module not found: node-fetch

[Baarsgaard]

Since the fetch implementation is figured out at runtime as described here.
I'd like to add the "browser" field to the package.json too in order to fix bundlers like webpack.
You can see more about the "browser" field here.

In short, this is a better fix than modifying (in my case non-existent) tsconfig.json

[jcchavezs]

Thanks @Raunow for the fix and the details. Any input on this @anuraaga?

[jcchavezs]

Is this also related to #465?

[Baarsgaard]

Is this also related to #465?

Short answer no, long answer:

As far as I can tell, it's not the same issue.
As long as you don't use the following functions:

os.userInfo()
os.getPriority()
os.version()
os.setPriority(0)

No errors will be thrown by an up-to-date chromium based browser.
And I didn't get any errors from webpack with require('os'), unlike require('node-fetch').

For reference the Zipkin npm package only makes use of os.networkInterfaces()

That said, it could possible solve the problem as os.networkInterfaces() just returns an empty object { } in browsers.

[anuraaga]

Seems to make sense, thanks

[jcchavezs]

Thanks @Raunow I will publish a release very soon but in case you want to try the package, you can use the canary release:

A new version of the package zipkin-transport-http (0.22.1-alpha.5) was published at 2021-01-28T14:14:12.467Z from
35.196.72.151. The shasum of this package was ec6aef17241f32dbf9f90a3b101f9db742496a0f.