Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/58161 global stage administration #17358

Open
wants to merge 33 commits into
base: dev
Choose a base branch
from
Open

Feature/58161 global stage administration #17358

wants to merge 33 commits into from

Conversation

toy
Copy link
Contributor

@toy toy commented Dec 4, 2024

Ticket

OP#58161

What are you trying to accomplish?

Allow global stage administration

Merge checklist

  • Added/updated tests
  • Added/updated documentation in Lookbook (patterns, previews, etc)
  • Tested major browsers (Chrome, Firefox, Edge, ...)

@toy toy force-pushed the feature/58161-global-stage-administration branch 6 times, most recently from 799692d to 516961c Compare December 11, 2024 19:39
@toy toy force-pushed the feature/58161-global-stage-administration branch 3 times, most recently from 01f3ec8 to 9d10847 Compare December 12, 2024 19:06
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 13, 2024
View reviewed changes
app/models/application_record.rb Dismissed Show dismissed Hide dismissed
@toy toy changed the base branch from dev to feature/58163-project-specific-stage-administration December 13, 2024 14:35
@toy toy force-pushed the feature/58161-global-stage-administration branch 2 times, most recently from b5aa03b to ef3ae5d Compare December 13, 2024 14:39
Base automatically changed from feature/58163-project-specific-stage-administration to dev December 16, 2024 08:37
@toy toy force-pushed the feature/58161-global-stage-administration branch from 312461a to 01e2e41 Compare December 16, 2024 14:45
ulferts
ulferts requested changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@ulferts ulferts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @toy,

I am aware that the PR is not yet done so sorry if I criticised anything you would have done anyway.

But the general direction is already looking good so I thought I could start on the details :).

app/components/settings/project_life_cycle_step_definitions/form_header_component.html.erb Outdated Show resolved Hide resolved
app/controllers/admin/settings/project_life_cycle_step_definitions_controller.rb Outdated Show resolved Hide resolved
app/components/settings/project_life_cycle_step_definitions/row_component.html.erb Show resolved Hide resolved
app/components/settings/project_life_cycle_step_definitions/row_component.html.erb Show resolved Hide resolved
app/controllers/admin/settings/project_life_cycle_step_definitions_controller.rb Outdated Show resolved Hide resolved
app/helpers/highlighting_helper.rb Show resolved Hide resolved
app/models/application_record.rb Show resolved Hide resolved
app/views/admin/settings/project_life_cycle_step_definitions/form.html.erb Outdated Show resolved Hide resolved
config/locales/en.yml Show resolved Hide resolved
config/locales/en.yml Outdated Show resolved Hide resolved
@toy toy force-pushed the feature/58161-global-stage-administration branch 2 times, most recently from b63fae5 to d66c408 Compare December 17, 2024 19:17
@toy toy force-pushed the feature/58161-global-stage-administration branch 2 times, most recently from 2e8f962 to 8928e68 Compare December 18, 2024 13:26
@github-actions github-actions bot temporarily deployed to gh-6899875-pr-17358 December 18, 2024 13:26 Inactive
@toy toy force-pushed the feature/58161-global-stage-administration branch from 8928e68 to a85a8a0 Compare December 18, 2024 14:08
@github-actions github-actions bot temporarily deployed to gh-6899875-pr-17358 December 18, 2024 14:08 Inactive
@toy toy force-pushed the feature/58161-global-stage-administration branch from a85a8a0 to 57a392e Compare December 18, 2024 15:08
@github-actions github-actions bot temporarily deployed to gh-6899875-pr-17358 December 18, 2024 15:09 Inactive
@github-actions github-actions bot temporarily deployed to gh-6899875-pr-17358 December 18, 2024 15:13 Inactive
ulferts
ulferts requested changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@ulferts ulferts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only found one thing that actually needs fixing and that one is tiny.

db/migrate/20241217190533_add_uniqueness_index_to_project_life_cycle_step_definitions_name.rb Outdated Show resolved Hide resolved
app/components/projects/settings/life_cycle_steps/step_component.html.erb Show resolved Hide resolved
lookbook/previews/open_project/enterprise_edition/banner_component_preview.rb Show resolved Hide resolved
app/controllers/admin/settings/project_life_cycle_step_definitions_controller.rb Outdated Show resolved Hide resolved
toy added 17 commits December 18, 2024 18:00
@toy
cleanup row component
d13a8bd
@toy
add menu, handle moving and destroying
481559a
@toy
{,row-,column-}gap-? classes
527bb06
@toy
handle drag-n-drop ordering, except for expected turbo stream response
97586a2
@toy
simplify ApplicationRecord.most_recently_changed
4bddf95
@toy
highlight_css_updated_at should depend on Project::LifeCycleStepDefin…
4820c7d 
…ition too
@toy
rename border box filter bulkActionContainer target to hideWhenFiltering
4a984a7
@toy
hide movement controls when filtering
0e6309e
@toy
require enterprise token
db30792
@toy
combine subheaders with filter and buttons
d21ebbf
@toy
fix title for form
d887cef
@toy
handle responses for destroy/move/drop using turbo streams
44c2147
@toy
no need for global error messages for life cycle step definition form
13a1016
@toy
move allowed_to_customize_life_cycle? to a module
40b1402
@toy
make both life cycle project settings and definitions list behave whe…
a97cc73 
…n name is too long
@toy
change heading description
799ed5d
@toy
fix color input size, after it was enabled by #17482
43183be
@toy toy force-pushed the feature/58161-global-stage-administration branch from 1eaf7b3 to 43183be Compare December 18, 2024 17:00
@toy toy marked this pull request as ready for review December 18, 2024 17:00
@github-actions github-actions bot temporarily deployed to gh-6899875-pr-17358 December 18, 2024 17:08 Inactive
@github-actions github-actions bot temporarily deployed to gh-6899875-pr-17358 December 18, 2024 18:02 Inactive
@github-actions github-actions bot temporarily deployed to gh-6899875-pr-17358 December 18, 2024 19:19 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcalcobe marcalcobe marcalcobe left review comments

@ulferts ulferts ulferts requested changes

Assignees
No one assigned
Labels
pullpreview
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@toy @ulferts @marcalcobe