add repoproc for allow_auto_merge #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| return change.success() | ||
|
|
||
| if not repo.allow_auto_merge: |
There was a problem hiding this comment.
Why this check? Doesn't this mean we'll only create a Change if the repo doesn't already allow AM? But surely we still want to if it does and we're unsetting it? Plus this makes the if in 364 always False, no?
neither have I. 😬 And you're right, this code is sus. The reason for it is that GitHub Copilot dutifully created a function with the exact same pattern as the one above, which has the same logic bug. Together with #17 this should make more sense now. I'll still test it in a quiet minute tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.