fix (auto-update): Fix auto-updating parameters

optimizely · Jun 10, 2019 · ab98118 · ab98118
1 parent 241abce
commit ab98118
Show file tree

Hide file tree

Showing 7 changed files with 1,041 additions and 148 deletions.
diff --git a/demo/app.js b/demo/app.js
@@ -22,7 +22,7 @@ const optimizely = optimizelyExpressSdk.initialize({
   sdkKey: 'CZsVVgn6j9ce6fNPt2ZEiB',
   datafileOptions: {
     autoUpdate: true,
-    updateInterval: 600000 // 10 minutes in milliseconds
+    updateInterval: 5*1000 // 5 seconds in milliseconds
   },
 });
 app.use(optimizely.middleware);

diff --git a/demo/express-sdk.js b/demo/express-sdk.js
@@ -1,5 +1,5 @@
 /**
- * Optimizely Express SDK
+ * Optimizely Express Middleware
  *
  * Copyright 2019, Optimizely
  *
@@ -40,13 +40,15 @@ function initialize(options) {
     sdkKey,
     datafile,
     logLevel,
+    datafileOptions,
   } = options;
 
 
   const defaultLogger = require('@optimizely/optimizely-sdk').logging;
   const manager = new DatafileManager({
     sdkKey,
-    ...options
+    ...options,
+    ...datafileOptions,
   });
 
   function updateDatafile() {
@@ -76,7 +78,10 @@ function initialize(options) {
         logger: defaultLogger.createLogger({
           logLevel: logLevel
         }),
-        ...options
+        ...options,
+        datafileOptions: {
+          autoUpdate: false, // Ensure the SDK doesn't also try to auto-update on its own
+        },
       });
 
       req.optimizely = {
@@ -140,7 +145,7 @@ function initialize(options) {
     },
 
     /**
-     * isRouteEnabled
+     * isRouteEnabled (EXPERIMENTAL-FEATURE)
      *
      * Provides a method which can be used to block a route in express on whether the feature is enabled or not
      *