Events to micronaut version 4.3.4 #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
ChaimaaeROUAI
requested review from
alvarosanchez,
Julia3072,
d-kozak and
OthmanMilahOracle
alvarosanchez
requested changes
May 17, 2024
| * The event to track. | ||
| */ | ||
| @Serdeable | ||
| public class Event { |
| * Event record. | ||
| */ | ||
| @Serdeable | ||
| public class EventRecord extends Event { |
| * Defines whether events were received. | ||
| */ | ||
| @Serdeable | ||
| public class EventsReceived { |
Comment on lines
4
to
7
| test-resources: | ||
| containers: | ||
| kafka: | ||
| image-name: "confluentinc/cp-kafka:7.3.3" |
There was a problem hiding this comment.
Do we need this specific version? Can we not use Test Resources' default?
Comment on lines
1
to
3
| kafka: | ||
| bootstrap: | ||
| servers: localhost:9092 |
There was a problem hiding this comment.
Remove, this is provided by Test Resources
alvarosanchez
approved these changes
Jun 4, 2024
GH-OIM
approved these changes
Jun 7, 2024
Julia3072
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.