Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraalJSScriptEngine: NPE when setting empty engine bindings #849

Open
wants to merge 1 commit into
base: release/graal-vm/23.1
Choose a base branch
from

Conversation

simonis
Copy link
Contributor

@simonis simonis commented Sep 26, 2024

Fixes #839

Cherry picked from:
69c6c87: GraalJSScriptEngine: NPE when setting empty engine bindings
16d63fa: Correction of the year in the copyright header.

According to our discussion at the GraalVM Community Workshop I'd like to revitalize the release/graal-vm/23.1 branch and downport this trivial fix which already landed in the upstream master branch.

This fix is required to pass the Java 21 JCK tests if the GraalJS module is bundled (i.e. "jlinked") with the JDK as a system module.

Fixes oracle#839

Cherry picked from:
69c6c87: GraalJSScriptEngine: NPE when setting empty engine bindings
16d63fa: Correction of the year in the copyright header.
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Sep 26, 2024
@woess woess requested a review from iamstolis October 2, 2024 15:33
@toddjonker
Copy link

Is there anything blocking this backport to 23.1 ?

@iamstolis
Copy link
Member

Is there anything blocking this backport to 23.1 ?

In fact, these changes have been backported internally already. They should be part of 23.1.6 (that should be released early next year). I am just afraid that the corresponding team and their automated backporting process ignores public backport PRs.

@toddjonker
Copy link

@iamstolis I'm not sure what is meant by "backported internally". I do see that the change landed in the master branch on Aug 29, but our production deployment is running 23.1

Sorry, what I should've said explicitly is that I'd like to see this on the release/graal-vm/23.1 branch as Volker requested herein, since that's what we build in sync with our GraalVM CE build.

@iamstolis
Copy link
Member

I'm not sure what is meant by "backported internally".

It means that it is in an internal branch that will serve as a base of the next 21.3.x CPU release. This branch is not mirrored on GitHub because it may contain security fixes that should not be visible until the corresponding release is available. These changes will be merged into release/graal-vm/23.1 as a part of the release process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants