Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fixes and detail page implementation #1

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

astha-iOS
Copy link

@astha-iOS astha-iOS commented Jun 7, 2021

Bug Fixes

  • Set constarints of tableCell labels and image
  • Set titleLabel and description label in max two line on list page
  • Remove the api function from cellForRow at indexPath
  • Write api function in RestApi name class which is written in swift language.
  • Pass api response ops view controller and parse json using PhotoModel class
  • Add Pagination on FoodItemListVC
  • Each page get 20 data after 20 data call api again and new data append in previous array.

New Feature

  • Creat a DetailViewController
  • On DetailViewController add image view in larger size and also add number of view , owner name , title , descriptions.
  • Add UISegmentedControl on food item list view controller for sort list according date added , date updated
  • Add switch for accending, descending order

Further Improvement

  • Add some animations on UI
  • Write unit test cases for Api class
  • Send items on list view controller with another ways : Using protocol delegate, using completionHandler

Prerequisite: Xcode 9+ installation

How to run

  • First clone progect from git repository.
  • Move inside ios-tech-challenge directory
  • Checkout branch astha-iOS:master: git checkout astha-iOS:master
  • Open codeChallenge.xcodeproj
  • Go to target and set Automatic manage signing
  • Run the application

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant