Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zmq_poll
appears broken on win64 due to the fact that the fd slot in the poll struct is a uint64 on that OS. The most recent version of libzmq uses the typezmq_fd_t
to account for this. Unfortunately. there are versions of libzmq around on Windows and elsewhere that don't have this type. Older versions just had a#ifdef
directly in the struct definition subsituting theSOCKET
type on Windows. To account for this I used a read-time conditional instead.The original issue is from common-lisp-jupyter, The details are at the very bottom of the issue.
yitzchak/common-lisp-jupyter#65 (comment)