cmake: allow compilation on Fedora-like systems finding Eigen3 #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fedora-like systems struggle to find eigen library properly by filling only EIGEN3_INCLUDE_DIR. This patch allows in such cases to be able to compile the package. This patch changes the way in which Eigen3 is found according to the ROS Jade migration document: http://wiki.ros.org/jade/Migration#Eigen_CMake_Module_in_cmake_modules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason CentOS installs a custom CMake module
FindEigen3.cmakeat/usr/share/cmake/Moduleswhich does not setEIGEN3_INCLUDE_DIRSand take precedence over/usr/share/cmake/Eigen3Config.cmake:https://git.centos.org/rpms/eigen3/c/f12352f2c337bd9af314b28ca69d330f5de44b69?branch=c8
This patch changes the way in which Eigen3 is found according to the ROS Jade migration guide:
http://wiki.ros.org/jade/Migration#Eigen_CMake_Module_in_cmake_modules
The important part is