Skip to content

Commit

Permalink
Fix wrong computation of alert description height
Browse files Browse the repository at this point in the history
Refs: #100
Signed-off-by: Matthias Meulien <[email protected]>
  • Loading branch information
orontee committed Nov 23, 2024
1 parent 188d475 commit 2296011
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 3 deletions.
7 changes: 7 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,13 @@ The format is based on [Keep a
Changelog](https://keepachangelog.com/en/1.0.0/), and this project
adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [1.10.1 - 2024-11-23]

### Changed

- Fix wrong computation of alert description height
[#100](https://github.com/orontee/taranis/issues/100)

## [1.10.0 - 2024-11-20]

### Added
Expand Down
2 changes: 1 addition & 1 deletion meson.build
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
project(
'taranis',
'cpp',
version: '1.10.0',
version: '1.10.1',
meson_version: '>= 0.61.2',
default_options : [
'cpp_std=c++17',
Expand Down
4 changes: 2 additions & 2 deletions src/alerts.cc
Original file line number Diff line number Diff line change
Expand Up @@ -149,8 +149,8 @@ void AlertViewer::identify_scrollable_area() {
this->alert_description_text.c_str(), ALIGN_LEFT);

this->min_scrollable_view_offset =
-std::max(0, alert_title_height + description_height -
this->scrollable_view_rectangle.h);
-std::max(0, alert_title_height + 2 * AlertViewer::vertical_padding +
description_height - this->scrollable_view_rectangle.h);
}

void AlertViewer::update_title_text() {
Expand Down

0 comments on commit 2296011

Please sign in to comment.