Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(license): check versions when npm.license is missing #6

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

macklinu
Copy link

See #5

I wanted to contribute a fix for #5, but it looks like I'm not mocking node-fetch properly in the tests, and I believe the danger test snapshot changed to the latest danger README (aka it's fetching data from the network in the tests). If you could help out on this, that'd be awesome. I think this is the general fix desired - open to feedback! 😄

@orta
Copy link
Owner

orta commented Sep 12, 2017

oh damn, I missed this 👍

@orta
Copy link
Owner

orta commented Sep 12, 2017

wanna rebase and we'll get it in?

@glensc
Copy link
Contributor

glensc commented Mar 22, 2022

Re-created as #53

it was difficult to rebase because everything that could be done wrong was done with the contribution:

  1. changing unrelated lines
  2. committing everything as a single commit
  3. undescriptive commit messages

@glensc
Copy link
Contributor

glensc commented Mar 22, 2022

Also, I don't understand what is the problem that is attempted to fix, the description is not useful to me:

@glensc
Copy link
Contributor

glensc commented Oct 21, 2022

Since received zero feedback to re-created pr of this:

closed it.

@glensc
Copy link
Contributor

glensc commented Oct 21, 2022

i think this one should be closed too, nobody is interested on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants