Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add basic document on matching rules support for header fields #819

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

m-guesnon-pvotal
Copy link

@m-guesnon-pvotal m-guesnon-pvotal commented May 18, 2022

Related Issue or Design Document

Related source code pull request can be found here: ory/oathkeeper#967

Checklist

  • I have read the contributing guidelines
    and signed the CLA.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got green light (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added necessary documentation within the code base (if
    appropriate).

Further comments

@CLAassistant
Copy link

CLAassistant commented May 18, 2022

CLA assistant check
All committers have signed the CLA.

@m-guesnon-pvotal m-guesnon-pvotal marked this pull request as ready for review May 18, 2022 21:19
@vinckr vinckr added the upstream Issue is caused by an upstream dependency. label May 3, 2023
@vinckr
Copy link
Member

vinckr commented May 3, 2023

added the upstream label to make clear this is waiting for the PR in oathkeeper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upstream Issue is caused by an upstream dependency.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants