-
-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update go-jose to v3.0.0 #746
Conversation
This commit updates go-jose from v2.5.2 to v3.0.0
91f70cb
to
5867db4
Compare
@aeneasr can you provide some guidance on how to get the conformity tests to pass? The tests are failing when trying to compile https://github.com/ory/hydra/blob/872720b3c0d92341a78791004ded44ac8d4ff7c8/client/client.go#L24. This is because the |
I would recommend forking hydra, configure a replacement so it utilizes this branches latest commit, and then see what's wrong and needs fixing. On face value the only issue appears to be that the github.com/ory/hydra/v2/client struct |
@james-d-elliott I agree about
Until this PR is merged there is no |
Since this change has no bearing on actual code and is just imports I'd recommend that you discuss the change with the maintainers (to plan it out and get there thoughts of migrating to a completely different package, as this is a breaking change) and in the meantime use the go mod replace tooling. Side note, I'd be cautious about moving to that package until someone with some fairly detalied knowledge about the JOSE specs has had time to review it and its compatibility with fosite. Also regarding hydra being able to use it, you can actually do it. See this PR which does exactly that: ory/hydra#3403 specifically this line: https://github.com/ory/hydra/pull/3403/files#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6R247 |
The version was bumped in 3c2721e |
This commit updates
go-jose
fromv2.5.2
tov3.0.0
.It contains a fix 1 for an issue that is stopping us from updating the version of
fosite
that we use.Footnotes
https://github.com/go-jose/go-jose/commit/4ac8eda113724c926632d14de694dbf1ff70d2cc ↩