Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pkce): session generated needlessly #759

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

james-d-elliott
Copy link
Contributor

This fixes an issue where the PKCE sessions are generated needlessly which also leads to errors in some circumstances.

Related Issue or Design Document

Fixes #743

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@james-d-elliott james-d-elliott marked this pull request as ready for review August 2, 2023 19:39
@james-d-elliott james-d-elliott force-pushed the fix-pkce branch 2 times, most recently from a4cb2da to 9c0e4b6 Compare August 4, 2023 03:58
This fixes an issue where the PKCE sessions are generated needlessly which also leads to errors in some circumstances.
Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@aeneasr aeneasr merged commit c16a2d1 into ory:master Feb 13, 2024
5 checks passed
@james-d-elliott james-d-elliott deleted the fix-pkce branch February 13, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing to fetch a PKCE request session fails requests even when PKCE is not enforced
2 participants