Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: decode id_token_hint with correct signer #770

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: decode id_token_hint with correct signer #770

wants to merge 2 commits into from

Conversation

hijiki51
Copy link

BREAKING CHANGE: this patch changes OpenIDConnectTokenStrategy interface.

Related Issue or Design Document

#769

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@hijiki51 hijiki51 requested a review from aeneasr as a code owner September 23, 2023 05:19
@hijiki51 hijiki51 force-pushed the fix-id-token-hint-decoder branch from 6cf0f2c to 49ad669 Compare March 23, 2024 06:06
hijiki51 added 2 commits August 3, 2024 22:47
@hijiki51
fix: decode id_token_hint with correct signer
e2730ee 
BREAKING CHANGE: this commit changed OpenIDConnectTokenStrategy interface.

closes ory#769
@hijiki51
test: add test for DecodeIDToken
263e457
@hijiki51 hijiki51 force-pushed the fix-id-token-hint-decoder branch from 49ad669 to 263e457 Compare August 3, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitar mitar mitar approved these changes

@aeneasr aeneasr Awaiting requested review from aeneasr aeneasr is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hijiki51 @mitar