Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add client_id and client_secret to revokeOAuth2Token #3373

Merged

Conversation

jonas-jonas
Copy link
Member

Related issue(s)

Supersedes #3261

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@jonas-jonas jonas-jonas requested a review from aeneasr as a code owner November 28, 2022 15:58
aeneasr
aeneasr previously approved these changes Nov 28, 2022
@jonas-jonas jonas-jonas marked this pull request as draft November 28, 2022 16:10
@jonas-jonas jonas-jonas force-pushed the fix/revokeOAuth2TokenClientIdClientSecret branch from 367154d to 3b29393 Compare November 30, 2022 18:31
@jonas-jonas
Copy link
Member Author

@aeneasr I don't actually think the values are required. Removed the required: true tag. Seems that the tests confirm this. PTAL.

@jonas-jonas jonas-jonas marked this pull request as ready for review November 30, 2022 18:45
@codecov
Copy link

codecov bot commented Nov 30, 2022

Codecov Report

Merging #3373 (3b29393) into master (4ee4456) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3373   +/-   ##
=======================================
  Coverage   76.95%   76.95%           
=======================================
  Files         123      123           
  Lines        8964     8964           
=======================================
  Hits         6898     6898           
  Misses       1639     1639           
  Partials      427      427           
Impacted Files Coverage Δ
oauth2/handler.go 68.51% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@aeneasr aeneasr merged commit 93bac07 into ory:master Dec 1, 2022
harnash pushed a commit to Wikia/ory-hydra that referenced this pull request Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants