fix: jwk generation incorrectly being skipped #3876
Conversation
… duplica…" This reverts commit d5f65c5.
aeneasr
changed the title
|
Oh that's too bad. Under what condition was jwk generation being skipped? |
|
It's basically like a cache for calling the same function twice, which is a side effect in a multi-threaded app. It just behaves not like expected under certain circumstances and returns the wrong keys. |
|
Yeah but only when there's another inflight call for the same result. Kid was intentionally left out of the key because all callers didn't rely on the kid anyways, it is just a random uuid. Does this have to do with multi tenancy? I can imagine the network id would be important there. Maybe that should be included in the flight key? |
|
@aeneasr Do we need a new/reopened issue to fix this? Seems fairly important. |
|
Just reopen the other one. We're not observing these issues on our prod system, if the fix is easy we're happy to do it, but we're not heavily incentivized to fix it due to lack of commercial demand and already having spent a good portion of time on it. |
Unfortunately, #3870 introduced a regression in the JWK generation logic.
Reverts #3870