Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: require redirect_uri in openid requests #3900

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Dec 4, 2024

Resolves a deviation from the OpenID Connect spec, where the redirect_uri was not required when performing flows with scope=openid.

BREAKING CHANGE: Going forward, OAuth2 Clients requesting an OpenID Connect flow must include the redirect_uri parameter or the request will be rejected.

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

Resolves a deviation from the OpenID Connect spec, where the `redirect_uri` was not required when performing flows with `scope=openid`.

BREAKING CHANGE: Going forward, OAuth2 Clients requesting an OpenID Connect flow **must** include the `redirect_uri` parameter or the request will be rejected.
@aeneasr aeneasr requested review from hperl and alnr as code owners December 4, 2024 09:05
@aeneasr aeneasr merged commit 5caa629 into master Dec 4, 2024
31 checks passed
@aeneasr aeneasr deleted the use-fosite-master branch December 4, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant