Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update helm set-file example #648

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Conversation

till
Copy link
Contributor

@till till commented Oct 31, 2023

This is just a minor doc "fix", as it turns out, you can't use "-" in helm. And I took the example to literal. Hope that's alright.

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Turns out, you can't use "-" in helm.
Copy link
Collaborator

@Demonsthere Demonsthere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, yaml can be picky with key names 😅 I see no reason why not not merge this

@Demonsthere Demonsthere merged commit e70d228 into ory:master Nov 2, 2023
12 checks passed
@till till deleted the patch-1 branch November 2, 2023 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants