Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow setting env vars for hydra-maester #721

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

ariep
Copy link
Contributor

@ariep ariep commented Dec 12, 2024

Add a deployment.extraEnv value to the hydra-maester helm chart for setting environment variables.

Related Issue or Design Document

Fixes #650.

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

I followed the example of the hydra chart, using the same variable name.

@ariep ariep force-pushed the hydra-maester-env branch from 3e309c8 to 2423c1d Compare December 12, 2024 13:04
Copy link
Collaborator

@Demonsthere Demonsthere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! :)

@Demonsthere Demonsthere merged commit f2d1b84 into ory:master Dec 12, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hydra Maester chart does not allow env variables, but maester v0.0.31 requires it
2 participants