fix: don't leak goroutines if there are no files to watch #822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeneasr
approved these changes
Nov 22, 2024
alnr
force-pushed
the
alnr/fix-configx-spawn
branch
from
8dff5c8 to
d76a18a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where we were leaking many goroutines especially during tests, even though there are no files to watch.
Those goroutines are cancelable via the context passed in, but we rarely do that in test code. And if we do, we spawn literally thousands of goroutines before doing one big cancel at the end.
IMO, this whole watching code should either go away or be refactored so it is more obvious that it spawns background goroutines.