Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bootc-image-builder/main: extend version command (HMS-5211) #761

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

schuellerf
Copy link
Contributor

@schuellerf schuellerf commented Dec 17, 2024

Extend version with printing also the timestamp and "tainted" if not all files are checked in.
Also support calling it with --version, -v or version.

JIRA: HMS-5211

@schuellerf
Copy link
Contributor Author

/jira-epic HMS-5208

@schutzbot schutzbot changed the title bootc-image-builder/main: extend version command bootc-image-builder/main: extend version command (HMS-5211) Dec 17, 2024
@schuellerf schuellerf force-pushed the enable-version-command branch from 511e009 to 47b150a Compare December 18, 2024 08:30
Copy link
Collaborator

@mvo5 mvo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I added some inline ideas/thoughts for your consideration :)

bib/cmd/bootc-image-builder/main.go Outdated Show resolved Hide resolved
bib/cmd/bootc-image-builder/main.go Outdated Show resolved Hide resolved
bib/cmd/bootc-image-builder/main.go Outdated Show resolved Hide resolved
bib/cmd/bootc-image-builder/main.go Show resolved Hide resolved
@schuellerf schuellerf force-pushed the enable-version-command branch from 47b150a to 889109f Compare December 20, 2024 18:33
@schuellerf schuellerf requested a review from mvo5 December 20, 2024 18:34
Extend version with printing also the timestamp and
"tainted" if not all files are checked in.
Also support calling it with `--version` or `-v`.
@schuellerf schuellerf force-pushed the enable-version-command branch from 889109f to 55aee70 Compare December 20, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants