Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce pre-commit / make lint #39

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

schuellerf
Copy link
Contributor

Introduce pre-commit linting with make lint.
Also add this to github actions.

Copy link
Collaborator

@mvo5 mvo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This is very nice and I love that I will be able to do "make lint" now :) Tiny suggestion/question about what commit should introduce what files but otherwise great stuff.

@@ -0,0 +1,32 @@
---
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(nitpick) this probably is better suited for the next commit, i.e. this one cleans up the existing code to be "lint" ready, the next "adds the linting" but it seems this file fits better into the part(?)

@@ -0,0 +1,2 @@
[FORMAT]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(nitpick) this probably is better suited for the next commit, i.e. this one cleans up the existing code to be "lint" ready, the next "adds the linting" but it seems this file fits better into the part(?)

@@ -0,0 +1,10 @@
---
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(nitpick) this probably is better suited for the next commit, i.e. this one cleans up the existing code to be "lint" ready, the next "adds the linting" but it seems this file fits better into the part(?)

@@ -0,0 +1,2 @@
[pep8]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(nitpick) this probably is better suited for the next commit, i.e. this one cleans up the existing code to be "lint" ready, the next "adds the linting" but it seems this file fits better into the part(?)

@@ -0,0 +1,5 @@
[MESSAGES CONTROL]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(nitpick) this probably is better suited for the next commit, i.e. this one cleans up the existing code to be "lint" ready, the next "adds the linting" but it seems this file fits better into the part(?)

@@ -0,0 +1,4 @@
[MESSAGES CONTROL]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(nitpick) this probably is better suited for the next commit, i.e. this one cleans up the existing code to be "lint" ready, the next "adds the linting" but it seems this file fits better into the part(?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants