-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce pre-commit / make lint
#39
base: main
Are you sure you want to change the base?
Conversation
Also make the linters part of the github actions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! This is very nice and I love that I will be able to do "make lint" now :) Tiny suggestion/question about what commit should introduce what files but otherwise great stuff.
@@ -0,0 +1,32 @@ | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(nitpick) this probably is better suited for the next commit, i.e. this one cleans up the existing code to be "lint" ready, the next "adds the linting" but it seems this file fits better into the part(?)
@@ -0,0 +1,2 @@ | |||
[FORMAT] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(nitpick) this probably is better suited for the next commit, i.e. this one cleans up the existing code to be "lint" ready, the next "adds the linting" but it seems this file fits better into the part(?)
@@ -0,0 +1,10 @@ | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(nitpick) this probably is better suited for the next commit, i.e. this one cleans up the existing code to be "lint" ready, the next "adds the linting" but it seems this file fits better into the part(?)
@@ -0,0 +1,2 @@ | |||
[pep8] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(nitpick) this probably is better suited for the next commit, i.e. this one cleans up the existing code to be "lint" ready, the next "adds the linting" but it seems this file fits better into the part(?)
@@ -0,0 +1,5 @@ | |||
[MESSAGES CONTROL] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(nitpick) this probably is better suited for the next commit, i.e. this one cleans up the existing code to be "lint" ready, the next "adds the linting" but it seems this file fits better into the part(?)
@@ -0,0 +1,4 @@ | |||
[MESSAGES CONTROL] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(nitpick) this probably is better suited for the next commit, i.e. this one cleans up the existing code to be "lint" ready, the next "adds the linting" but it seems this file fits better into the part(?)
Introduce pre-commit linting with
make lint
.Also add this to github actions.