Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional ignore entries #100

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Add additional ignore entries #100

merged 1 commit into from
Dec 8, 2023

Conversation

jrusz
Copy link
Contributor

@jrusz jrusz commented Dec 8, 2023

This repo is no longer being maintained. In order to get at least some testing for new nightlies I'm adding all currently failing entries to the db-ignore file. Most of them are ostree/edge which should not work here in the first place.

This repo is no longer being maintained. In order to get at least some
testing for new nightlies I'm adding all currently failing entries to
the db-ignore file. Most of them are ostree/edge which should not work
here in the first place.
@jrusz
Copy link
Contributor Author

jrusz commented Dec 8, 2023

Considering this repo is basically in deprecation mode we agreed with @lavocatt that makes sense to just add all the currently failing test cases to the db-ignore to get at least some testing on the new nightlies before this can be taken over by the images repository. Most of them are edge type images which should be there in the first place, the only one that really stood out to me is ova image type. I just hope it won't create a false sense of "all is good" but since we're testing all the important image types in integration tests in osbuild-composer repository I think we should be good. The pipeline passed here https://gitlab.com/redhat/services/products/image-builder/ci/manifest-db/-/pipelines/1100165687 when I tried it manually before opening this MR and Schutzbot even created a PR to update the db: #99

What do you think about this @atodorov @achilleas-k ?

@jrusz jrusz mentioned this pull request Dec 8, 2023
@achilleas-k
Copy link
Member

I think that's fine. I have some thoughts about changing this repo to download images and manifests from the ones that are generated in osbuild/images CI and maintain image-info on those, as a reference database. But no one has time to work on that now so let's keep this as it is for now, make it green, and revisit it another time.

@achilleas-k achilleas-k merged commit de7c4e6 into main Dec 8, 2023
8 checks passed
@achilleas-k achilleas-k deleted the add-ignore branch December 8, 2023 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants