Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add checks for whether nvidia-docker2 is installed #103

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tfoote
Copy link
Collaborator

@tfoote tfoote commented Nov 19, 2020

Fixes #88

@tfoote tfoote added the nvidia Connected to the nvidia extension label Nov 19, 2020
@tfoote tfoote force-pushed the detect_nvidia_docker branch from e519430 to 8e10651 Compare November 24, 2020 09:09
@codecov
Copy link

codecov bot commented Nov 24, 2020

Codecov Report

Merging #103 (8e10651) into master (228125c) will decrease coverage by 2.41%.
The diff coverage is 34.37%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #103      +/-   ##
==========================================
- Coverage   86.89%   84.48%   -2.42%     
==========================================
  Files           7        7              
  Lines         595      625      +30     
==========================================
+ Hits          517      528      +11     
- Misses         78       97      +19     
Impacted Files Coverage Δ
src/rocker/nvidia_extension.py 82.10% <13.33%> (-12.90%) ⬇️
src/rocker/core.py 88.88% <52.94%> (-1.98%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 228125c...8e10651. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
nvidia Connected to the nvidia extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[nvidia extension] Detect an unsupported nvidia driver
2 participants