Added install pkgs extension #295
Conversation
There was a problem hiding this comment.
In general I'm not super enthusiastic about enabling arbitrary package strings here. In particular that's very platform specific and potentially version specific. Installing a large number of packages at startup time can be very costly as well. And this content isn't cached effectively.
At the first level I'd like to see something with an interface that is more generic and uses something like the rosdep keys to be cross platform. You mention in your comments about adding standard groupings. I think those standard groupings will be much more powerful for individuals, but they're going to be pretty user specific. I'd like to find a way to enable people to make those groupings and share them such that they can be batched up . An example is the --dev-helpers extension where those are my personal simple tools that I used as a test case. But that approach doesn't really scale well. If there's a group that wants to share and distribute an extension with that batching that gets to a level of management that might work. But also if you're looking to add a bunch of packages it's likely a better solution to build a new base image before using rocker. Raw packages are not what rocker is designed for, they don't require being responsive to the local environment.
| def precondition_environment(self, cli_args): | ||
| pass | ||
|
|
||
| def validate_environment(self, cli_args): |
There was a problem hiding this comment.
This should at least validate the environment here is debian if this will only work for debian packages.
There was a problem hiding this comment.
Does validate_environment get called anywhere? It seems like it's not used unless I'm missing something
There was a problem hiding this comment.
Well that's a regression. It should be being validated at the build stage. It looks like that was lost along the way.
| @@ -0,0 +1,7 @@ | |||
| # User specified additional packages | |||
| RUN export DEBIAN_FRONTEND=noninteractive; \ | |||
There was a problem hiding this comment.
This template only works for debian like systems. It should be documented.
I've been using this extension for a while and figured it was generic enough to be added to the main repo. If it's redundant in some way please let me know as I find this extension handy to add additional developer packages