Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(GitHub): Enforce version 1.1.2 of the reuse tool #7172

Closed
wants to merge 1 commit into from

Conversation

mnonnenmacher
Copy link
Member

The recently published version 2.0.0 of the reuse tool 1 reports several issues which require updating the configuration. As it is not clear yet how much effort this requires, fix the version to the previous release 1.1.2. Note that other projects are having issues with the new release as well 2, so it might make sense to wait a bit before upgrading.

The recently published version 2.0.0 of the reuse tool [1] reports
several issues which require updating the configuration. As it is not
clear yet how much effort this requires, fix the version to the previous
release 1.1.2. Note that other projects are having issues with the new
release as well [2], so it might make sense to wait a bit before upgrading.

[1]: https://github.com/fsfe/reuse-tool/releases/tag/v2.0.0
[2]: fsfe/reuse-tool#773

Signed-off-by: Martin Nonnenmacher <[email protected]>
@mnonnenmacher mnonnenmacher requested a review from a team as a code owner June 21, 2023 20:11
@sschuberth
Copy link
Member

While I had problems with the new version as well in CI, a simple retrigger solved it, as the new version as withdrawn ("yanked") by now IIUC: fsfe/reuse-tool@09cc236#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4edR126

@sschuberth
Copy link
Member

sschuberth commented Jun 21, 2023

Also see fsfe/reuse-tool#773 (comment). So what I'm trying to say is: I don't think we need this change (anymore / currently).

@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (5bb199c) 64.53% compared to head (d938e8e) 64.53%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #7172   +/-   ##
=========================================
  Coverage     64.53%   64.53%           
  Complexity     1972     1972           
=========================================
  Files           334      334           
  Lines         16725    16725           
  Branches       2399     2399           
=========================================
  Hits          10793    10793           
  Misses         4885     4885           
  Partials       1047     1047           
Flag Coverage Δ
funTest-docker 69.24% <ø> (ø)
funTest-non-docker 27.99% <ø> (ø)
test 40.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mnonnenmacher mnonnenmacher deleted the reuse-1.1.2 branch June 24, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants