Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for several invalid versions #701

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mgdcvetko
Copy link
Contributor

Hi, we noticed that five packages had invalid versions listed in their advisories. It's the same mistake across all advisories - version 1 is listed, while malicious packages actually published version 1.0 and never just 1.
This PR would fix this in all five OSSF published advisories, and I will also fix this in our reports in the AWS bucket.

Mentioning @rhalar for visibility.

Signed-off-by: mcvetko <[email protected]>
@@ -15,7 +15,7 @@
"versions": [
"1.0.0rc1",
"1.0.0rc2",
"1",
"1.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have to bring this up again, just to make sure we're in sync with @calebbrown, and handling this correctly.

So our procedure usually is that when non-additive changes happen to an advisory, we withdraw the advisory and generate a new one, with a new ID. This generates 'extra' advisories and withdrawals, and since the OSSF doesn't handle withdrawals automatically we decided to fix up existing ones manually for these smaller scale issues. This was already done in #673

This is why there are two entries in malicious-packages-origins for RLMA-2024-03512
https://github.com/ossf/malicious-packages/blob/main/osv/malicious/pypi/admcheck/MAL-2024-4732.json#L48

@calebbrown commented that this is okay, since the 'history' is preserved #673 (comment)

But that worked because the whole bucket was reprocessed from the start last time, which I don't believe will be the case anymore?
If we plan to manually edit existing advisories now, we probably need to generate a new entry in malicious-packages-origins as well?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If an additional version is added, it might be better to publish a new updated version of the report with the correct version(s), with a higher number (or an RLUP- report).

This would be merged and add the version the report.

Removing the "1" currently must be done manually.

If you'd prefer I can update all the versions in this PR.

@calebbrown
Copy link
Contributor

This PR is not entirely necessary as far as Python is concerned.

According to the version spec "1" and "1.0" refer to the exact same version of a package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants