Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust/tests: Adjust for new ostree #3051

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

cgwalters
Copy link
Member

The rust tests do two things:

  • Parse the error output from the binary, which broke when the new ostree hit Fedora stable
  • Source the libtest.sh test suite, which broke when we dropped the trivial-httpd binary by default

@github-actions github-actions bot added the area/rust-bindings Relates to the Rust bindings for the C library label Sep 19, 2023
@cgwalters
Copy link
Member Author

Gotta love when CI technical debt just roars out of nowhere and slams into you

Because it's now at the toplevel.
@cgwalters
Copy link
Member Author

OK, I think we have a winner now...

@cgwalters cgwalters disabled auto-merge September 20, 2023 12:50
@cgwalters
Copy link
Member Author

/override continuous-integration/jenkins/pr-merge

@openshift-ci
Copy link

openshift-ci bot commented Sep 20, 2023

@cgwalters: Overrode contexts on behalf of cgwalters: continuous-integration/jenkins/pr-merge

In response to this:

/override continuous-integration/jenkins/pr-merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Collaborator

@ericcurtin ericcurtin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM

@ericcurtin ericcurtin merged commit cd606aa into ostreedev:main Sep 20, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/rust-bindings Relates to the Rust bindings for the C library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants