Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edge pages now display gallery and datasheets, drop downs work #661

Merged
merged 2 commits into from
Mar 8, 2018
Merged

Edge pages now display gallery and datasheets, drop downs work #661

merged 2 commits into from
Mar 8, 2018

Conversation

baileysingleton
Copy link
Contributor

fixes issue #645 #648

Changes in this PR.

  • Edge Datasheets and galleries display correctly
  • Add Datasheet/ Export/ Add Gallery item drop downs now work in Edge

Testing this PR.

  1. Load up Edge
  2. Go to Site Detail, logged in as admin
  3. See Gallery Items, datasheet items, drop downs working

@osuosl/devs

NathanTan
NathanTan approved these changes Mar 8, 2018
View reviewed changes
Copy link

@NathanTan NathanTan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bailey said it works, I'll take his word.

@baileysingleton baileysingleton merged commit 9eeb571 into develop Mar 8, 2018
@ramereth ramereth deleted the bugfix/edge_params branch January 5, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NathanTan NathanTan NathanTan approved these changes

@hertelc hertelc Awaiting requested review from hertelc

@jerry-peng jerry-peng Awaiting requested review from jerry-peng

@CarvellWakeman CarvellWakeman Awaiting requested review from CarvellWakeman

Assignees
No one assigned
Labels
Ready for Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@baileysingleton @NathanTan