use streaming/iterators, swap eyes, fix audio, add option to use depth video file #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed the program to work with iterators, which means everything is processed frame by frame and my PC can convert a whole movie without running out of memory.
While I was doing that, I also set the correct FPS for the output video,
fixed the audio (I think moviepy doesn't want to write over a file it's also reading from),
and swapped the views so that the left view is on the left.
I got rid of the depth data cache too. Instead I added an option to read the depth map from a video file.
Sorry about putting so much stuff into the PR. I started with the streaming/iterators and changed some other stuff along the way.
I noticed too late that the
fixing_app
branch is newer. It should be possible to port these changes over.