interactive pyqtgraph viewer #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following changes are suggested:
viewer.pyto house the new viewer code.yielditerator to a classFrame_readerthat itself is an iterator. Then in addition one can get images using__getitem__or[]syntax.cli/pfs_raw.pyto instead of showing image with OpenCV use the new viewer.Uncertainties:
FirstFrameNoattribute in header)?Frame_readerclass have a possibility to followFirstFrameNoas above?pyqtandpyqtgraph? (I did not get it to work in venv)The code has not the type suggestions that has been added to the rest of the code base but that can be fixed when the code looks good. Otherwise, I am open for suggestions.
A response to #24