Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix table colors / re-allow customization #127

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

fix table colors / re-allow customization #127

wants to merge 10 commits into from

Conversation

jmonster
Copy link
Contributor

@jmonster jmonster commented Dec 13, 2024 •
edited
Loading

  • adds backdrop-blur-sm to blank (e.g. checkbox cells) and pinned columns
    • other cells can appear below them when scrolling, so we need to obscure that, especially when the bg is transparent
  • deletes hard coded variables that prevent outside styling
  • corrects class names for some table coloring
  • defaults to white/black for table bg

@jmonster jmonster requested a review from Brayden December 13, 2024 15:51
@jmonster jmonster self-assigned this Dec 13, 2024
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Dec 13, 2024 •
edited
Loading

Deploying astra with  Cloudflare Pages  Cloudflare Pages

Latest commit: 466564b
Status: ✅  Deploy successful!
Preview URL: https://a16b1d4d.astra-avc.pages.dev
Branch Preview URL: https://table-colors.astra-avc.pages.dev

View logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Brayden Brayden Awaiting requested review from Brayden

At least 1 approving review is required to merge this pull request.

Assignees

@jmonster jmonster

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jmonster