-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to include or exclude files in the testing coverage #15840
Open
abenjaminov
wants to merge
14
commits into
oven-sh:main
Choose a base branch
from
abenjaminov:jaco/coverage-include-exclude
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add option to include or exclude files in the testing coverage #15840
abenjaminov
wants to merge
14
commits into
oven-sh:main
from
abenjaminov:jaco/coverage-include-exclude
+155
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…enjaminov/bun into jaco/coverage-include-exclude
abenjaminov
changed the title
Jaco/coverage include exclude
Add option to include or exclude files in the testing coverage
Dec 18, 2024
Jarred-Sumner
requested changes
Dec 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR.
- Instead of linking and including PCRE2, you can use
bun.glob
to match globs - This will need tests, which you can see examples of in the
test
folder
kudos |
Thanks for the reply, i have incorperated bun.glob for this and wrote a few testing cases |
…enjaminov/bun into jaco/coverage-include-exclude
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for filtering files included or excluded from coverage during
bun test
. The feature allows users to specifycoverageInclude
andcoverageExclude
options in their configuration. Both glob patterns and regular expressions are supported.For example:
How did you verify your code works?
patterns.zig
and verified they pass.matchesGlob
,isGlobPattern
,matchesRegex
, andmatchesAnyPattern
functions to confirm correctness.coverageInclude
andcoverageExclude
settings work as intended with a sample test configuration.For Zig changes: