-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mounts for docker-compose-dev-services #33
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In principle, this is a great new feature! Please add some docs about it to the README. Also, please add a changelog entry https://docs.tutor.overhang.io/tutor.html#contributing
@Faraz32123 what's the status of this PR? |
@cmltaWt0 was going to test it and then change the name from DRAFT. |
@regisb @Faraz32123 |
1526f4e
to
2510e86
Compare
@regisb @Faraz32123 I've added the changelog, switched the target branch to master. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR is adding the ability to do a local development for credentials.
I am trying to use the plugin for local development but the process of adding mounts doesn't work for me.
Am I missing something or mounts should be considered in
local-docker-compose-dev-services
?--
How to test:
The same effect we can achieve by manually removing our mount from
./root/env/dev/docker-compose.yml
and then invoking config save command:I'll test against
master
branch and post command to make it works with all console output.Then change the DRAFT status to ready.