Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: fix and upgrade to quince #10

Closed
wants to merge 3 commits into from
Closed

feat: fix and upgrade to quince #10

wants to merge 3 commits into from

Conversation

Abdul-Muqadim-Arbisoft
Copy link
Contributor

@Abdul-Muqadim-Arbisoft Abdul-Muqadim-Arbisoft commented Nov 19, 2023 •
edited
Loading

Description: Upgrading the tutor web plugin to quince.

Updates made :

  • Removed the line ctx.parent.command.commands = {} from cli.py, causing issues in webui shell.
  • Updated the click repl version to latest 0.3.0
  • Updated version of plugin form 16.0.0 to 17.0.0
  • Updated release from palm to quince
  • Added DS_store in gitignore which is added by macOS to prevent unnecessary file commit

@Abdul-Muqadim-Arbisoft Abdul-Muqadim-Arbisoft marked this pull request as draft November 19, 2023 08:27
@Abdul-Muqadim-Arbisoft Abdul-Muqadim-Arbisoft marked this pull request as ready for review November 19, 2023 08:30
@Abdul-Muqadim-Arbisoft Abdul-Muqadim-Arbisoft changed the title feat: upgrade to quince feat: Fix and upgrade to quince Nov 28, 2023
@Abdul-Muqadim-Arbisoft Abdul-Muqadim-Arbisoft changed the title feat: Fix and upgrade to quince feat: fix and upgrade to quince Nov 28, 2023
hinakhadim
hinakhadim reviewed Nov 28, 2023
View reviewed changes
setup.py Outdated Show resolved Hide resolved
@hinakhadim
Copy link
Collaborator

LGTM!

@regisb
Copy link
Contributor

regisb commented Dec 9, 2023

Closed in favour of #11

@regisb regisb closed this Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hinakhadim hinakhadim hinakhadim approved these changes

Assignees

@hinakhadim hinakhadim

Labels
None yet
Projects
Tutor project management
Status: Won't fix
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Abdul-Muqadim-Arbisoft @hinakhadim @regisb