Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: corrected click context management in TutorCli, resolves #14 #13

Merged
merged 3 commits into from
Mar 26, 2024
Merged

fix: corrected click context management in TutorCli, resolves #14 #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fbc38cd
Corrected Click context management in TutorCli
Abdul-Muqadim-Arbisoft Feb 28, 2024
081b072
Code reformatted
Abdul-Muqadim-Arbisoft Feb 28, 2024
0292f9e
added changelog entry
Abdul-Muqadim-Arbisoft Mar 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/20240326_115811_abdul.muqadim_fix_click_context_management.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- [Improvement] This is a non-breaking change. Removed unnecessary command clearing in context parent, simplifying the context handling. (by @Abdul-Muqadim-Arbisoft)
2 changes: 0 additions & 2 deletions tutorwebui/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,8 +116,6 @@ def shell() -> None:
# Retrieve the current Click context. The context is used to manage the state
# and pass around internal objects within the Click framework.
ctx = click.get_current_context()
if ctx.parent and ctx.parent.command:
ctx.parent.command.commands = {} # type: ignore

while True:
try:
Expand Down
Loading