Skip to content

Commit

Permalink
fix docker + typescript shenanigans
Browse files Browse the repository at this point in the history
  • Loading branch information
justincorrigible committed Nov 24, 2020
1 parent 4ac5197 commit 3be83cc
Show file tree
Hide file tree
Showing 7 changed files with 10 additions and 14 deletions.
8 changes: 4 additions & 4 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ RUN \
apt-get clean

# nvm environment variables
ENV NODE_VERSION 15.2.0
ENV NODE_VERSION 15.2.1
ENV NVM_DIR /root/.nvm

# NODE & NPM
Expand All @@ -33,14 +33,14 @@ ENV NODE_PATH $NVM_DIR/v$NODE_VERSION/lib/node_modules
ENV PATH $NVM_DIR/versions/node/v$NODE_VERSION/bin:$PATH

RUN mkdir -p /srv
ADD billing-api /srv/billing-api
ADD billing-ui /srv/billing-ui
COPY billing-api /srv/billing-api
COPY billing-ui /srv/billing-ui

# UI
WORKDIR /srv/billing-ui
RUN \
yarn install && \
# yarn add node-sass --force && \
ls -a && ls config -a && \
yarn run build

# API
Expand Down
4 changes: 1 addition & 3 deletions billing-invoice/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@

FROM node AS prebuilder

RUN npm install -g typescript

WORKDIR /app
COPY src/ /app/src/
COPY \
Expand All @@ -15,7 +13,7 @@ COPY \
# Build JS
RUN \
yarn install && \
tsc -p .
npx tsc -p .

##
# Jetison the prebuilder to keep the image compact
Expand Down
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ const { merge } = require('webpack-merge');
const HtmlWebpackPlugin = require('html-webpack-plugin');
const CaseSensitivePathsPlugin = require('case-sensitive-paths-webpack-plugin');

const baseConfig = require('./webpack.config.base');
const baseConfig = require('./webpack.base');
const paths = require('./paths');
const { target: targetEndpoint } = require('../config');

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ const HtmlWebpackPlugin = require('html-webpack-plugin');
const MiniCssExtractPlugin = require('mini-css-extract-plugin');
const url = require('url');

const baseConfig = require('./webpack.config.base');
const baseConfig = require('./webpack.base');
const paths = require('./paths');

const homepagePath = require(paths.appPackageJson).homepage;
Expand Down
4 changes: 2 additions & 2 deletions billing-ui/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -102,8 +102,8 @@
"serialize-javascript": "^5.0.1"
},
"scripts": {
"build": "webpack --config ./config/webpack.config.prod.js --progress",
"dev": "node --trace-deprecation node_modules/webpack/bin/webpack serve --config ./config/webpack.config.dev.js"
"build": "webpack --config ./config/webpack.prod.js --progress",
"dev": "node --trace-deprecation node_modules/webpack/bin/webpack serve --config ./config/webpack.dev.js"
},
"eslintConfig": {
"extends": [
Expand Down
4 changes: 1 addition & 3 deletions invoice-api/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@

FROM node AS prebuilder

RUN npm install -g typescript

WORKDIR /app
COPY src/ /app/src/
COPY \
Expand All @@ -15,7 +13,7 @@ COPY \
# Build JS
RUN \
yarn install && \
tsc -p .
npx tsc -p .


##
Expand Down

0 comments on commit 3be83cc

Please sign in to comment.