Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

committing changes related to Visa permissions schema #688

Merged
merged 1 commit into from
Apr 26, 2023
Merged

committing changes related to Visa permissions schema #688

merged 1 commit into from
Apr 26, 2023

Conversation

Azher2Ali
Copy link
Contributor

Added many to many relationship to Visa - Permissions.
Also created a service class which does not impact #679 and which is further used in #680

@Azher2Ali Azher2Ali requested review from joneubank and leoraba April 25, 2023 18:19
joneubank
joneubank approved these changes Apr 26, 2023
View reviewed changes
Copy link
Contributor

@joneubank joneubank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good here.

I wonder if we should rename entity to policyId since thats what it is referencing. Took me a while to determine which property was referencing the ID from ACL policies since entity is so generic.

@Azher2Ali
Copy link
Contributor Author

wonder if we should rename entity to policyId since thats what it is referencing. Took me a while to determine which property was referencing the ID from ACL policies since entity is so generic.

This change has been taken as part of current ticket #680

@Azher2Ali Azher2Ali closed this Apr 26, 2023
@Azher2Ali Azher2Ali reopened this Apr 26, 2023
@Azher2Ali Azher2Ali merged commit 140c081 into feature/develop-passport Apr 26, 2023
@Azher2Ali Azher2Ali deleted the feature/visaPermissions branch April 26, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joneubank joneubank joneubank approved these changes

@leoraba leoraba Awaiting requested review from leoraba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Azher2Ali @joneubank