Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/version 3 #1033

Open
wants to merge 34 commits into
base: master
Choose a base branch
from
Open

Feature/version 3 #1033

wants to merge 34 commits into from

Conversation

owen2345
Copy link
Owner

@owen2345 owen2345 commented Jan 8, 2023

  • Configure docker for local setup
  • Use some getting-started documentation as the default content
  • Improve performance
    • Refactor custom fields/custom field group
  • Refactor/improve web documentation
  • Improve admin UI for easier and more intuitive usage
  • Improve and add missing tests (unit and end-to-end)
  • Improve code quality and code style
    • Frontend
    • Backend
  • Add shell service to generate the entire app (rails + camaleon + docker settings)
  • Reduce third-party gem dependencies
  • Upgrade tinymce 4 to 5 and 5 to 6 (Optional)
  • Refactor or replace features
    - [ ] New uploader
    - [ ] New built-in theme that uses the same frontend stack as the admin theme so we don't have any additional dependencies.

Some discussions here: #1027
Please do not hesitate to add/edit/remove topics from the list

Copy link
Collaborator

@texpert texpert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with the suggestion to craft a 2.7.0 release from the current master. and then merge this and all other PRs prepairing to v3

Also, I think it would be better, for clarity, to have the topics in the description of this PR as some issues with a v3 milestone, each of them being addressed in a separate PR

Copy link
Collaborator

@brian-kephart brian-kephart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for kicking this off @owen2345!

  • Improve code quality and code style

@texpert has been working on using ESlint. Should we use RuboCop or StandardRB for the Ruby code as well?

  • Reduce third-party gem dependencies

will-paginate-bootstrap, jquery-rails, sass-rails, maybe draper? Any others?

  • Upgrade tinymce 4 to 5 and 5 to 6 (Optional)

I submitted a PR for this a long time ago that wasn't merged due to being a potentially breaking change. I'll have to see if I can dig it up. It required some changes, but worked well.

Things to add:

  • New uploader
  • New built-in theme that uses the same frontend stack as the admin theme so we don't have any additional dependencies.

@owen2345
Copy link
Owner Author

Just as a note: This branch could act as a v3 version and move the current master branch into v2 (once v3 is released) which in the future we can continue doing basic support, like security issues.

@owen2345
Copy link
Owner Author

owen2345 commented Jan 12, 2023

Thanks for kicking this off @owen2345!

  • Improve code quality and code style

@texpert has been working on using ESlint. Should we use RuboCop or StandardRB for the Ruby code as well?

  • Reduce third-party gem dependencies

will-paginate-bootstrap, jquery-rails, sass-rails, maybe draper? Any others?

  • Upgrade tinymce 4 to 5 and 5 to 6 (Optional)

I submitted a PR for this a long time ago that wasn't merged due to being a potentially breaking change. I'll have to see if I can dig it up. It required some changes, but worked well.

Things to add:

  • New uploader
  • New built-in theme that uses the same frontend stack as the admin theme so we don't have any additional dependencies.

@brian-kephart this version v3 is indeed the release where we can include all the breakable changes with quality, security, performance, and usability in mind (lets try to include a way to migrate from v2 into v3 or add a script or library to help with the migration or try to add the backward compatibility)

  • Regarding code style, I vote for rubocop, what about you @texpert @brian-kephart ?
  • Regarding new things, updated in the PR list

@texpert
Copy link
Collaborator

texpert commented Jan 12, 2023

+1 for rubocop

@brian-kephart brian-kephart added this to the Version 3 milestone Feb 7, 2023
@texpert texpert force-pushed the feature/version-3 branch from 9f39e4b to d9836ff Compare March 12, 2023 19:23
@texpert texpert force-pushed the feature/version-3 branch from 5ca0006 to 50731e0 Compare April 9, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants