-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/version 3 #1033
base: master
Are you sure you want to change the base?
Feature/version 3 #1033
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with the suggestion to craft a 2.7.0 release from the current master. and then merge this and all other PRs prepairing to v3
Also, I think it would be better, for clarity, to have the topics in the description of this PR as some issues with a v3 milestone, each of them being addressed in a separate PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for kicking this off @owen2345!
- Improve code quality and code style
@texpert has been working on using ESlint. Should we use RuboCop or StandardRB for the Ruby code as well?
- Reduce third-party gem dependencies
will-paginate-bootstrap, jquery-rails, sass-rails, maybe draper? Any others?
- Upgrade tinymce 4 to 5 and 5 to 6 (Optional)
I submitted a PR for this a long time ago that wasn't merged due to being a potentially breaking change. I'll have to see if I can dig it up. It required some changes, but worked well.
Things to add:
- New uploader
- New built-in theme that uses the same frontend stack as the admin theme so we don't have any additional dependencies.
Just as a note: This branch could act as a v3 version and move the current master branch into v2 (once v3 is released) which in the future we can continue doing basic support, like security issues. |
@brian-kephart this version v3 is indeed the release where we can include all the breakable changes with quality, security, performance, and usability in mind (lets try to include a way to migrate from v2 into v3 or add a script or library to help with the migration or try to add the backward compatibility)
|
+1 for |
9f39e4b
to
d9836ff
Compare
5ca0006
to
50731e0
Compare
9840124
to
e2085c5
Compare
Bumps [json5](https://github.com/json5/json5) from 1.0.1 to 1.0.2. - [Release notes](https://github.com/json5/json5/releases) - [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md) - [Commits](json5/json5@v1.0.1...v1.0.2) --- updated-dependencies: - dependency-name: json5 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
…ess` to avoid capybara-screenshot errors
e2085c5
to
fe61e0f
Compare
- [ ] New uploader
- [ ] New built-in theme that uses the same frontend stack as the admin theme so we don't have any additional dependencies.
Some discussions here: #1027
Please do not hesitate to add/edit/remove topics from the list