Skip to content
This repository has been archived by the owner on Dec 3, 2019. It is now read-only.

Add make tasks for l10n sync #68

Closed
wants to merge 2 commits into from
Closed

Add make tasks for l10n sync #68

wants to merge 2 commits into from

Conversation

tboerger
Copy link

Currently there are no unified make tasks to handle the localization
sync. This is my effort to integrate it to keep the CI jobs simple to
handle that.

Signed-off-by: Thomas Boerger [email protected]

@CLAassistant
Copy link

CLAassistant commented Sep 12, 2018

CLA assistant check
All committers have signed the CLA.

@tboerger
Copy link
Author

Failing build is absolutely not related to this PR :(

@DeepDiver1975
Copy link
Contributor

Failing build is absolutely not related to this PR :(

indeed

@phil-davis
Copy link
Contributor

phil-davis commented Sep 12, 2018

Heizenberg was messing with CI here earlier today also, I noticed another job that failed similarly. I restarted drone. Issue #69 raised.

@codecov-io
Copy link

codecov-io commented Sep 12, 2018

Codecov Report

Merging #68 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #68   +/-   ##
=========================================
  Coverage     79.11%   79.11%           
  Complexity      214      214           
=========================================
  Files            26       26           
  Lines           905      905           
=========================================
  Hits            716      716           
  Misses          189      189

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebd52bf...58c131e. Read the comment docs.

@tboerger
Copy link
Author

To enforce the same tasks for the majority of the apps in a central way we could also do something like that:

Makefile

.PHONY: l10n
l10n: l10n-rules.mk

l10n-rules.mk:
	wget -q https://raw.githubusercontent.com/owncloud/administration/master/core/l10n-rules.mk

-include l10n-rules.mk

l10n-rules.mk

.PHONY: l10n-push
l10n-push:
	cd l10n && tx -d push -s --skip --no-interactive

.PHONY: l10n-pull
l10n-pull:
	cd l10n && tx -d pull -a --skip --minimum-perc=75

.PHONY: l10n-clean
l10n-clean:
	find l10n -type f -name \*.po -or -name \*.pot | xargs rm -f
	find l10n -type f -name uz.\* -or -name yo.\* -or -name ne.\* -or -name or_IN.\* | xargs git rm -f

.PHONY: l10n-read
l10n-read: l10n/l10n.pl
	perl l10n/l10n.pl $(app_name) read

.PHONY: l10n-write
l10n-write: l10n/l10n.pl
	perl l10n/l10n.pl $(app_name) write

l10n/l10n.pl:
	wget -qO l10n/l10n.pl https://rawgit.com/ownclouders/7f3e2bdf09e6c7258850d770c0edaf0b/raw/d3ad1673b5449900f85a04f95cdf7e7149140c4f/l10n.pl

Usage

make l10n l10n-read l10n-push l10n-pull l10n-write

@tboerger
Copy link
Author

tboerger commented Oct 8, 2018

Ping @DeepDiver1975 @PVince81

@DeepDiver1975 DeepDiver1975 self-requested a review October 8, 2018 12:37
@DeepDiver1975
Copy link
Contributor

Fine by me - seems reasonable.

@PVince81
Copy link
Contributor

PVince81 commented Feb 5, 2019

needs to be aligned with latest changes from @DeepDiver1975 to the reference Makefile

@PVince81
Copy link
Contributor

aligned now

@PVince81
Copy link
Contributor

ohhh, the conflicts

tboerger and others added 2 commits February 12, 2019 16:54
Currently there are no unified make tasks to handle the localization
sync. This is my effort to integrate it to keep the CI jobs simple to
handle that.

Signed-off-by: Thomas Boerger <[email protected]>
@PVince81
Copy link
Contributor

conflicts resolved, should be ready for merge then

@tboerger
Copy link
Author

tboerger commented Sep 3, 2019

Since Drone 1.0.0 we got cronjob support, so every plugin can handle the translation sync on their own now.

@tboerger tboerger closed this Sep 3, 2019
@paulijar
Copy link

paulijar commented Sep 4, 2019

@tboerger So what should the plugin do to handle the translation sync? Is there any documentation?

@tboerger
Copy link
Author

tboerger commented Sep 4, 2019

We haven't migrated the plugin translation sync yet. A requirement would be running on drone ci.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants