Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] [full-ci] remove scenario examples that are only for ocis/reva #40581

Merged
merged 1 commit into from
Jan 17, 2023
Merged

[tests-only] [full-ci] remove scenario examples that are only for ocis/reva #40581

merged 1 commit into from
Jan 17, 2023

Conversation

PrajwolAmatya
Copy link
Contributor

@PrajwolAmatya PrajwolAmatya commented Jan 17, 2023 •
edited by grgprarup
Loading

Description

This PR clean up the scenario example tables that runs only for ocis/reva

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@CLAassistant
Copy link

CLAassistant commented Jan 17, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@phil-davis
Copy link
Contributor

@PrajwolAmatya FYI, you need to write "tests-only" in the PR title (not "test-only"). That will help the CI and update-docs bot to understand that the change does not touch an "real" source code.

@PrajwolAmatya PrajwolAmatya changed the title [test-only] remove scenario examples that are only for ocis/reva [tests-only] [full-ci] remove scenario examples that are only for ocis/reva Jan 17, 2023
@PrajwolAmatya PrajwolAmatya force-pushed the remove-ocis-reva-scenario-examples branch from c41026a to eafd5a4 Compare January 17, 2023 06:02
@SagarGi SagarGi mentioned this pull request Jan 17, 2023
Open
11 tasks
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

grgprarup
grgprarup approved these changes Jan 17, 2023
View reviewed changes
Copy link
Contributor

@grgprarup grgprarup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@grgprarup grgprarup requested a review from phil-davis January 17, 2023 09:16
@owncloud owncloud deleted a comment from update-docs bot Jan 17, 2023
@phil-davis phil-davis merged commit 9a9ff73 into owncloud:master Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grgprarup grgprarup grgprarup approved these changes

@phil-davis phil-davis phil-davis approved these changes

@SagarGi SagarGi Awaiting requested review from SagarGi

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@saw-jan saw-jan Awaiting requested review from saw-jan

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

Assignees

@PrajwolAmatya PrajwolAmatya

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PrajwolAmatya @CLAassistant @phil-davis @grgprarup