Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci] Remove scenario tag skipOnOcis from feature files #40597

Merged
merged 1 commit into from
Jan 24, 2023
Merged

[tests-only][full-ci] Remove scenario tag skipOnOcis from feature files #40597

merged 1 commit into from
Jan 24, 2023

Conversation

roshanlc
Copy link

@roshanlc roshanlc commented Jan 24, 2023 •
edited
Loading

Description

This PR removes scenario tag skipOnOcis from the feature files.

Related Issue

Part of issue

Motivation and Context

How Has This Been Tested?

  • CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@grgprarup grgprarup mentioned this pull request Jan 24, 2023
Open
11 tasks
@roshanlc roshanlc changed the title [tests-only][full-ci] Remove scenario tags toImplementOnOcis, notToImplementOnOcis, skipOnOcis [tests-only][full-ci] Remove scenario tag skipOnOcis from feature files Jan 24, 2023
@roshanlc roshanlc mentioned this pull request Jan 24, 2023
Merged
11 tasks
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

50.0% 50.0% Coverage
0.0% 0.0% Duplication

@roshanlc roshanlc marked this pull request as ready for review January 24, 2023 08:19
grgprarup
grgprarup approved these changes Jan 24, 2023
View reviewed changes
Copy link
Contributor

@grgprarup grgprarup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@grgprarup grgprarup requested a review from phil-davis January 24, 2023 08:25
saw-jan
saw-jan reviewed Jan 24, 2023
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phil-davis phil-davis merged commit 86c13e8 into owncloud:master Jan 24, 2023
@roshanlc roshanlc deleted the remove-ocis-implementation-tags branch January 24, 2023 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saw-jan saw-jan saw-jan left review comments

@grgprarup grgprarup grgprarup approved these changes

@phil-davis phil-davis phil-davis approved these changes

@SagarGi SagarGi Awaiting requested review from SagarGi

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

Assignees

@roshanlc roshanlc

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@roshanlc @phil-davis @grgprarup @saw-jan