Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci] Remove scenario tag @notToImplementOnOcis from feature files #40599

Merged
merged 2 commits into from
Jan 25, 2023
Merged

[tests-only][full-ci] Remove scenario tag @notToImplementOnOcis from feature files #40599

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c8501e6
Removed @notToImplementOnOcis tag from feature files
Jan 24, 2023
588ed71
Fixed indentation based on review suggestions
Jan 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions tests/acceptance/features/apiAuth/cors.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ Feature: CORS headers
| 1 | /config | 100 | 200 |
| 2 | /config | 200 | 200 |

@files_external-app-required @notToImplementOnOCIS
@files_external-app-required
Examples:
| ocs_api_version | endpoint | ocs-code | http-code |
| 1 | /apps/files_external/api/v1/mounts | 100 | 200 |
Expand Down Expand Up @@ -100,7 +100,7 @@ Feature: CORS headers
| 1 | /cloud/users | 997 | 401 |
| 2 | /cloud/users | 997 | 401 |

@files_external-app-required @notToImplementOnOCIS
@files_external-app-required
Examples:
| ocs_api_version | endpoint | ocs-code | http-code |
| 1 | /apps/files_external/api/v1/mounts | 100 | 200 |
Expand Down Expand Up @@ -166,7 +166,7 @@ Feature: CORS headers
| 1 | /cloud/users | 997 | 401 |
| 2 | /cloud/users | 997 | 401 |

@files_external-app-required @notToImplementOnOCIS
@files_external-app-required
Examples:
| ocs_api_version | endpoint | ocs-code | http-code |
| 1 | /apps/files_external/api/v1/mounts | 997 | 401 |
Expand Down
4 changes: 2 additions & 2 deletions tests/acceptance/features/apiAuth/corsOc10Issue34679.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@api @notToImplementOnOCIS
@api
Feature: CORS headers current oC10 behavior for issue-34679

Background:
Expand Down Expand Up @@ -36,7 +36,7 @@ Feature: CORS headers current oC10 behavior for issue-34679
| 1 | /cloud/users | 997 | 401 |
| 2 | /cloud/users | 997 | 401 |

@files_external-app-required @notToImplementOnOCIS
@files_external-app-required
Examples:
| ocs_api_version | endpoint | ocs-code | http-code |
| 1 | /apps/files_external/api/v1/mounts | 997 | 401 |
Expand Down
2 changes: 1 addition & 1 deletion tests/acceptance/features/apiAuth/filesAppAuth.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@api @notToImplementOnOCIS @issue-ocis-reva-28
@api @issue-ocis-reva-28
Feature: auth

Background:
Expand Down
2 changes: 1 addition & 1 deletion tests/acceptance/features/apiAuth/tokenAuth.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@api @notToImplementOnOCIS @issue-ocis-reva-28 @issue-ocis-reva-37
@api @issue-ocis-reva-28 @issue-ocis-reva-37
Feature: tokenAuth

Background:
Expand Down
4 changes: 2 additions & 2 deletions tests/acceptance/features/apiAuth/webDavAuth.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,13 @@ Feature: auth
| dav_path |
| /remote.php/webdav |

@smokeTest @notToImplementOnOCIS @issue-ocis-reva-28
@smokeTest @issue-ocis-reva-28
Scenario: using WebDAV with token auth
Given a new client token for "Alice" has been generated
When user "Alice" requests "/remote.php/webdav" with "PROPFIND" using basic token auth
Then the HTTP status code should be "207"

@smokeTest @notToImplementOnOCIS
@smokeTest
Scenario: using WebDAV with browser session
Given a new browser session for "Alice" has been started
When the user requests "/remote.php/webdav" with "PROPFIND" using the browser session
Expand Down
2 changes: 1 addition & 1 deletion tests/acceptance/features/apiAuthOcs/ocsDELETEAuthOc10Issue32068.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@api @files_sharing-app-required @notToImplementOnOCIS
@api @files_sharing-app-required
Feature: current oC10 behavior for issue-32068

@smokeTest @issue-32068 @issue-ocis-reva-30 @issue-ocis-reva-65 @skipOnBruteForceProtection @issue-brute_force_protection-112
Expand Down
6 changes: 3 additions & 3 deletions tests/acceptance/features/apiAuthOcs/ocsGETAuth.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ Feature: auth
Then the HTTP status code of responses on all endpoints should be "200"
And the OCS status code of responses on all endpoints should be "200"

@notToImplementOnOCIS @issue-ocis-reva-30 @issue-ocis-reva-28
@issue-ocis-reva-30 @issue-ocis-reva-28
Scenario: using OCS with token auth of a normal user
Given a new client token for "Alice" has been generated
When user "Alice" requests these endpoints with "GET" using basic token auth
Expand Down Expand Up @@ -182,7 +182,7 @@ Feature: auth
Then the HTTP status code of responses on all endpoints should be "401"
And the OCS status code of responses on all endpoints should be "997"

@notToImplementOnOCIS

Scenario: using OCS with browser session of normal user
Given a new browser session for "Alice" has been started
When the user requests these endpoints with "GET" using a new browser session
Expand Down Expand Up @@ -214,7 +214,7 @@ Feature: auth
Then the HTTP status code of responses on all endpoints should be "401"
And the OCS status code of responses on all endpoints should be "997"

@notToImplementOnOCIS

Scenario: using OCS with an app password of a normal user
Given a new browser session for "Alice" has been started
And the user has generated a new app password named "my-client"
Expand Down
2 changes: 1 addition & 1 deletion tests/acceptance/features/apiAuthOcs/ocsGETAuthFilesExternal.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@api @files_external-app-required @notToImplementOnOCIS
@api @files_external-app-required
Feature: auth

Background:
Expand Down
2 changes: 1 addition & 1 deletion tests/acceptance/features/apiAuthOcs/ocsGETAuthFilesExternalOc10Issue32068.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@api @notToImplementOnOCIS @files_external-app-required @issue-32068
@api @files_external-app-required @issue-32068
Feature: current oC10 behavior for issue-32068

Background:
Expand Down
2 changes: 1 addition & 1 deletion tests/acceptance/features/apiAuthOcs/ocsGETAuthOc10Issue32068.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@api @notToImplementOnOCIS @files_sharing-app-required @issue-32068
@api @files_sharing-app-required @issue-32068
Feature: current oC10 behavior for issue-32068

Background:
Expand Down
2 changes: 1 addition & 1 deletion tests/acceptance/features/apiAuthOcs/ocsPUTAuthOc10Issue38423.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@api @files_sharing-app-required @notToImplementOnOCIS
@api @files_sharing-app-required
#When this issue is fixed, please delete this file and use the one from ocsPUTAuth.feature
Feature: current oC10 behavior for issue-38423

Expand Down
4 changes: 2 additions & 2 deletions tests/acceptance/features/apiAuthWebDav/webDavCOPYAuth.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ Feature: COPY file/folder
| /remote.php/dav/files/%username%/PARENT/parent.txt |
Then the HTTP status code of responses on all endpoints should be "401"

@notToImplementOnOCIS @issue-ocis-reva-37
@issue-ocis-reva-37
Scenario: send COPY requests to webDav endpoints using token authentication should not work
Given token auth has been enforced
And a new browser session for "Alice" has been started
Expand All @@ -93,7 +93,7 @@ Feature: COPY file/folder
| /remote.php/dav/files/%username%/PARENT/parent.txt |
Then the HTTP status code of responses on all endpoints should be "401"

@notToImplementOnOCIS @issue-ocis-reva-37
@issue-ocis-reva-37
Scenario: send COPY requests to webDav endpoints using app password token as password
Given token auth has been enforced
And a new browser session for "Alice" has been started
Expand Down
2 changes: 1 addition & 1 deletion tests/acceptance/features/apiAuthWebDav/webDavCaseInsensitiveAuth.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@api @notToImplementOnOCIS
@api
Feature: usernames are case-insensitive in webDAV requests with app passwords

Background:
Expand Down
2 changes: 1 addition & 1 deletion tests/acceptance/features/apiAuthWebDav/webDavDELETEAuthOC10Issue40144.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@api @notToImplementOnOCIS
@api
Feature: delete file/folder

Background:
Expand Down
4 changes: 2 additions & 2 deletions tests/acceptance/features/apiAuthWebDav/webDavLOCKAuth.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ Feature: LOCK file/folder
| /remote.php/dav/files/%username%/PARENT/parent.txt |
Then the HTTP status code of responses on all endpoints should be "401"

@notToImplementOnOCIS @issue-ocis-reva-37
@issue-ocis-reva-37
Scenario: send LOCK requests to webDav endpoints using token authentication should not work
Given token auth has been enforced
And a new browser session for "Alice" has been started
Expand All @@ -92,7 +92,7 @@ Feature: LOCK file/folder
| /remote.php/dav/files/%username%/PARENT/parent.txt |
Then the HTTP status code of responses on all endpoints should be "401"

@notToImplementOnOCIS @issue-ocis-reva-37
@issue-ocis-reva-37
Scenario: send LOCK requests to webDav endpoints using app password token as password
Given token auth has been enforced
And a new browser session for "Alice" has been started
Expand Down
4 changes: 2 additions & 2 deletions tests/acceptance/features/apiAuthWebDav/webDavMKCOLAuth.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ Feature: create folder using MKCOL
| /remote.php/dav/files/%username%/PARENT/parent.txt |
Then the HTTP status code of responses on all endpoints should be "401"

@notToImplementOnOCIS @issue-ocis-reva-37
@issue-ocis-reva-37
Scenario: send MKCOL requests to webDav endpoints using token authentication should not work
Given token auth has been enforced
And a new browser session for "Alice" has been started
Expand All @@ -100,7 +100,7 @@ Feature: create folder using MKCOL
| /remote.php/dav/files/%username%/PARENT/parent.txt |
Then the HTTP status code of responses on all endpoints should be "401"

@notToImplementOnOCIS @issue-ocis-reva-37
@issue-ocis-reva-37
Scenario: send MKCOL requests to webDav endpoints using app password token as password
Given token auth has been enforced
And a new browser session for "Alice" has been started
Expand Down
4 changes: 2 additions & 2 deletions tests/acceptance/features/apiAuthWebDav/webDavMOVEAuth.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ Feature: MOVE file/folder
| /remote.php/dav/files/%username%/PARENT/parent.txt |
Then the HTTP status code of responses on all endpoints should be "401"

@notToImplementOnOCIS @issue-ocis-reva-37
@issue-ocis-reva-37
Scenario: send MOVE requests to webDav endpoints using token authentication should not work
Given token auth has been enforced
And a new browser session for "Alice" has been started
Expand All @@ -89,7 +89,7 @@ Feature: MOVE file/folder
| /remote.php/dav/files/%username%/PARENT/parent.txt |
Then the HTTP status code of responses on all endpoints should be "401"

@notToImplementOnOCIS @issue-ocis-reva-37
@issue-ocis-reva-37
Scenario: send MOVE requests to webDav endpoints using app password token as password
Given token auth has been enforced
And a new browser session for "Alice" has been started
Expand Down
2 changes: 1 addition & 1 deletion tests/acceptance/features/apiAuthWebDav/webDavMOVEAuthOC10Issue40144.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@api @notToImplementOnOCIS
@api
Feature: MOVE file/folder

Background:
Expand Down
4 changes: 2 additions & 2 deletions tests/acceptance/features/apiAuthWebDav/webDavPOSTAuth.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ Feature: get file info using POST
| /remote.php/dav/files/%username%/PARENT/parent.txt |
Then the HTTP status code of responses on all endpoints should be "401"

@notToImplementOnOCIS @issue-ocis-reva-37
@issue-ocis-reva-37
Scenario: send POST requests to webDav endpoints using token authentication should not work
Given token auth has been enforced
And a new browser session for "Alice" has been started
Expand All @@ -90,7 +90,7 @@ Feature: get file info using POST
| /remote.php/dav/files/%username%/PARENT/parent.txt |
Then the HTTP status code of responses on all endpoints should be "401"

@notToImplementOnOCIS @issue-ocis-reva-37
@issue-ocis-reva-37
Scenario: send POST requests to webDav endpoints using app password token as password
Given token auth has been enforced
And a new browser session for "Alice" has been started
Expand Down
4 changes: 2 additions & 2 deletions tests/acceptance/features/apiAuthWebDav/webDavPROPFINDAuth.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ Feature: get file info using PROPFIND
| /remote.php/dav/files/%username%/PARENT/parent.txt |
Then the HTTP status code of responses on all endpoints should be "401"

@notToImplementOnOCIS @issue-ocis-reva-37
@issue-ocis-reva-37
Scenario: send PROPFIND requests to webDav endpoints using token authentication should not work
Given token auth has been enforced
And a new browser session for "Alice" has been started
Expand All @@ -89,7 +89,7 @@ Feature: get file info using PROPFIND
| /remote.php/dav/files/%username%/PARENT/parent.txt |
Then the HTTP status code of responses on all endpoints should be "401"

@notToImplementOnOCIS @issue-ocis-reva-37
@issue-ocis-reva-37
Scenario: send PROPFIND requests to webDav endpoints using app password token as password
Given token auth has been enforced
And a new browser session for "Alice" has been started
Expand Down
4 changes: 2 additions & 2 deletions tests/acceptance/features/apiAuthWebDav/webDavPROPPATCHAuth.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ Feature: PROPPATCH file/folder
| /remote.php/dav/files/%username%/PARENT/parent.txt |
Then the HTTP status code of responses on all endpoints should be "401"

@notToImplementOnOCIS @issue-ocis-reva-37
@issue-ocis-reva-37
Scenario: send PROPPATCH requests to webDav endpoints using token authentication should not work
Given token auth has been enforced
And a new browser session for "Alice" has been started
Expand All @@ -90,7 +90,7 @@ Feature: PROPPATCH file/folder
| /remote.php/dav/files/%username%/PARENT/parent.txt |
Then the HTTP status code of responses on all endpoints should be "401"

@notToImplementOnOCIS @issue-ocis-reva-37
@issue-ocis-reva-37
Scenario: send PROPPATCH requests to webDav endpoints using app password token as password
Given token auth has been enforced
And a new browser session for "Alice" has been started
Expand Down
4 changes: 2 additions & 2 deletions tests/acceptance/features/apiAuthWebDav/webDavPUTAuth.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ Feature: get file info using PUT
| /remote.php/dav/files/%username%/PARENT/parent.txt |
Then the HTTP status code of responses on all endpoints should be "401"

@notToImplementOnOCIS @issue-ocis-reva-37
@issue-ocis-reva-37
Scenario: send PUT requests to webDav endpoints using token authentication should not work
Given token auth has been enforced
And a new browser session for "Alice" has been started
Expand All @@ -93,7 +93,7 @@ Feature: get file info using PUT
| /remote.php/dav/files/%username%/PARENT/parent.txt |
Then the HTTP status code of responses on all endpoints should be "401"

@notToImplementOnOCIS @issue-ocis-reva-37
@issue-ocis-reva-37
Scenario: send PUT requests to webDav endpoints using app password token as password
Given token auth has been enforced
And a new browser session for "Alice" has been started
Expand Down
12 changes: 6 additions & 6 deletions tests/acceptance/features/apiFavorites/favorites.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ Feature: favorite
| old |
| new |

@files_sharing-app-required @notToImplementOnOCIS
@files_sharing-app-required
Scenario Outline: moving a favorite file out of a share keeps favorite state
Given using <dav_version> DAV path
And user "Brian" has been created with default attributes and without skeleton files
Expand Down Expand Up @@ -181,7 +181,7 @@ Feature: favorite
| old |
| new |

@files_sharing-app-required @notToImplementOnOCIS
@files_sharing-app-required
Scenario Outline: sharer file favorite state should not change the favorite state of sharee
Given using <dav_version> DAV path
And user "Brian" has been created with default attributes and without skeleton files
Expand All @@ -196,7 +196,7 @@ Feature: favorite
| old |
| new |

@files_sharing-app-required @notToImplementOnOCIS
@files_sharing-app-required
Scenario Outline: sharee file favorite state should not change the favorite state of sharer
Given using <dav_version> DAV path
And user "Brian" has been created with default attributes and without skeleton files
Expand Down Expand Up @@ -224,7 +224,7 @@ Feature: favorite
| old |
| new |

@files_sharing-app-required @notToImplementOnOCIS
@files_sharing-app-required
Scenario Outline: favorite a file inside of a received share
Given using <dav_version> DAV path
And user "Brian" has been created with default attributes and without skeleton files
Expand All @@ -236,7 +236,7 @@ Feature: favorite
| old |
| new |

@files_sharing-app-required @notToImplementOnOCIS
@files_sharing-app-required
Scenario Outline: favorite a folder inside of a received share
Given using <dav_version> DAV path
And user "Brian" has been created with default attributes and without skeleton files
Expand All @@ -249,7 +249,7 @@ Feature: favorite
| old |
| new |

@files_sharing-app-required @notToImplementOnOCIS
@files_sharing-app-required
Scenario Outline: favorite a received share itself
Given using <dav_version> DAV path
And user "Brian" has been created with default attributes and without skeleton files
Expand Down
2 changes: 1 addition & 1 deletion tests/acceptance/features/apiFavorites/favoritesOc10Issue33840.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@api @notToImplementOnOCIS
@api
Feature: current oC10 behavior for issue-33840

Background:
Expand Down
2 changes: 1 addition & 1 deletion tests/acceptance/features/apiFederationToRoot1/etagPropagation.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@api @federation-app-required @files_sharing-app-required @notToImplementOnOCIS
@api @federation-app-required @files_sharing-app-required
Feature: propagation of etags between federated and local server

Background:
Expand Down
2 changes: 1 addition & 1 deletion tests/acceptance/features/apiFederationToRoot1/federated.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@api @federation-app-required @files_sharing-app-required @notToImplementOnOCIS
@api @federation-app-required @files_sharing-app-required
Feature: federated

Background:
Expand Down
2 changes: 1 addition & 1 deletion tests/acceptance/features/apiFederationToRoot1/federatedOc10Issue31276.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@api @federation-app-required @files_sharing-app-required @notToImplementOnOCIS
@api @federation-app-required @files_sharing-app-required
Feature: current oC10 behavior for issue-31276

Background:
Expand Down
2 changes: 1 addition & 1 deletion tests/acceptance/features/apiFederationToRoot1/savePublicShare.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@api @federation-app-required @files_sharing-app-required @notToImplementOnOCIS
@api @federation-app-required @files_sharing-app-required
Feature: Save public shares created by oC users

Background:
Expand Down
2 changes: 1 addition & 1 deletion tests/acceptance/features/apiFederationToRoot2/federated.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@api @federation-app-required @files_sharing-app-required @notToImplementOnOCIS
@api @federation-app-required @files_sharing-app-required
Feature: federated

Background:
Expand Down
2 changes: 1 addition & 1 deletion tests/acceptance/features/apiFederationToRoot2/federatedOc10Issue35839.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@api @federation-app-required @files_sharing-app-required @notToImplementOnOCIS
@api @federation-app-required @files_sharing-app-required
Feature: current oC10 behavior for issue-35839

Background:
Expand Down
2 changes: 1 addition & 1 deletion tests/acceptance/features/apiFederationToShares1/savePublicShare.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@api @federation-app-required @files_sharing-app-required @notToImplementOnOCIS
@api @federation-app-required @files_sharing-app-required
Feature: Save public shares created by oC users

Background:
Expand Down
2 changes: 1 addition & 1 deletion tests/acceptance/features/apiMain/appManagement.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@api @skipOnLDAP @notToImplementOnOCIS
@api @skipOnLDAP
Feature: AppManagement

Scenario: Update of patch version of an app
Expand Down
Loading