[tests-only][full-ci] Remove isTestingOnReva() and isTestingOnOcis() and their references #40625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SwikritiT
requested review from
saw-jan,
SagarGi,
SwikritiT,
amrita-shrestha and
phil-davis
|
Kudos, SonarCloud Quality Gate passed!
|
phil-davis
approved these changes
Feb 8, 2023
Comment on lines
39
to
41
| public static function isTestingOnOcisOrReva():bool { | ||
| return (self::isTestingOnOcis() || self::isTestingOnReva()); | ||
| return false; | ||
| } |
There was a problem hiding this comment.
Note: we can also remove this whole function. But that can be done in the next PR.
SwikritiT
reviewed
Feb 8, 2023
SwikritiT
reviewed
Feb 8, 2023
|
@roshanlc I merged this, because it is "a good thing". Please make another PR to remove |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes
isTestingOnOcis()andisTestingOnReva()functions and their references from the tests code-base.Related Issue
[QA] Cleanup API acceptance test code #40572
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: