Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: option to change UI language #3087

Open
wants to merge 1 commit into
base: unstable
Choose a base branch
from

Conversation

VityaSchel
Copy link

First time contributor checklist:

Contributor checklist:

Description

Feature request: #1877

This PR adds option to change app's UI language in settings under Appearance tab.
I've used native <select> tag and hardcoded all languages as <option> tags.
I've used dynamic CSS variables for theming and transition: var(--default-duration) for theme animation.

I've used userConfig which stores data to config.json (uiLanguage property) to save and load language set by user. If language isn't set yet, it falls back to default language, evaluating this: process.env.LANGUAGE || app.getLocale() || 'en'. After choosing language, app is restarted using app.relaunch(); app.exit();

I've added two events to ipc: get-ui-language, set-ui-language .

I've added two translation keys: uiLanguage, uiLanguageDescription.

@VityaSchel VityaSchel changed the base branch from unstable to clearnet April 29, 2024 23:16
@KeeJef
Copy link
Collaborator

KeeJef commented May 8, 2024

We have some design changes incoming for this one, mainly switching the select tag to the native multi select modal that we use in various places in the Session app (inviting members to communities) and strings changes

@KeeJef KeeJef added the Jira This ticket is being tracked in Jira label Jun 3, 2024
@KeeJef
Copy link
Collaborator

KeeJef commented Jun 3, 2024

Tracking internally via SES-2059

@Bilb Bilb changed the base branch from clearnet to unstable September 30, 2024 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Jira This ticket is being tracked in Jira
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants