Fix issues #44, #45, and #46 #47
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build fails if ninja isn't aware of the byproducts for libclarabel_c
This commit allows Clarabel.cpp to be consumed by other CMake projects via a call to `add_subdirectory`: ```cmake add_subdirectory(path/to/clarabel.cpp) ``` Other projects might have Clarabel.cpp as a git submodule, and this makes it easier to do so.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issues #44, #45, and #46. Each one is a relatively small fix, so I grouped them together.
Merging this PR ensures that the examples are built with C++14 (which eigen requires); it fixes an issue where ninja builds fail on a fresh download of the repo; and it adds support for using Clarabel.cpp via
add_subdirectory