Add support for match dates #526
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for displaying match dates in the UI. This allows placing trhe match date in a prominent position on the match page, where it is easy for players and admins to see. Making the match date available in the model will allow further features, such as sending notifications before a match or reminders to submit scores afterwards.
Add an interface to allow teams to request rescheduling matches, and for the opposing team to approve or deny the request. This allows teams to modify the match date without having to involve the admins. Match date rescheduling is enabled on a per-league basis. It is disabled by default for existing leagues and enabled by default for new leagues. Rescheduling requests conceptually are split into two states: pending and decided. Requests start pending, and cannot be edited. If a player wishes to propose a new match date, existing requests from them are self-denied. This prevents a user from requesting multiple match dates at once (which could be considered to be a limitation). The design was inspired by how transfers work. Notifications are sent to captains when a request is created or denied, and to all players when a request is approved. Admins can still edit the match date directly, but this will not notify players. This should reduce annoyance if admins want to fix historical match dates. If admins want to change the match date and notify the players, they can create a request and then accept it themselves. Alternatively, a 'send notifications' checkbox on the match edit page would also work. No validation of match dates is done. It is expected that wildly unreasonable match dates will be rejected by the opposing team. Future work could involve constraining match dates to the future, or to the current week for "weekly" leagues. Future work could involve integrating rescheduing with the existing schedule system. For example, the site could suggest the next available day, or flag unavailable days as such.
|
Hey @Forty-Bot, did just want to let you know we've seen this PR. We're currently looking to make the move to Rails 7 (#552) so once that's happened we'll have a better look at this. ozfortress will be happy to implement it on ozfortress.com along with hopefully logs.tf link fields support one day. |
|
so are either of these going to get merged tbh I would rather not have to rewrite this... |
|
I suggest rebasing this on master now that the rails upgrade has happened. I'll review this after that's done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to add support to OZFortress (and other leagues using citadel) to trends.tf, but in order to do that I need accurate match dates to associate matches with logs. Citadel doesn't currently have any support for match dates, so they end up being decided in match comms. This PR to adds support for match dates to Citadel. I hope you will use this for upcoming matches, or (even better) add match dates to old matches.